chenlica commented on code in PR #3598:
URL: https://github.com/apache/texera/pull/3598#discussion_r2404259635
##########
core/access-control-service/src/main/scala/edu/uci/ics/texera/service/resource/AccessControlResource.scala:
##########
@@ -115,18 +118,18 @@ class AccessControlResource extends LazyLogging {
@GET
@Path("/{path:.*}")
def authorizeGet(
- @Context uriInfo: UriInfo,
- @Context headers: HttpHeaders
- ): Response = {
+ @Context uriInfo: UriInfo,
Review Comment:
Why do you include these format changes?
##########
core/access-control-service/src/test/scala/edu/uci/ics/texera/AccessControlResourceSpec.scala:
##########
@@ -20,9 +20,21 @@ package edu.uci.ics.texera
import edu.uci.ics.texera.auth.JwtAuth
import edu.uci.ics.texera.auth.util.HeaderField
import edu.uci.ics.texera.dao.MockTexeraDB
-import edu.uci.ics.texera.dao.jooq.generated.enums.{PrivilegeEnum,
UserRoleEnum, WorkflowComputingUnitTypeEnum}
-import
edu.uci.ics.texera.dao.jooq.generated.tables.daos.{ComputingUnitUserAccessDao,
UserDao, WorkflowComputingUnitDao}
-import
edu.uci.ics.texera.dao.jooq.generated.tables.pojos.{ComputingUnitUserAccess,
User, WorkflowComputingUnit}
+import edu.uci.ics.texera.dao.jooq.generated.enums.{
Review Comment:
Why do you include these format changes?
##########
deployment/k8s/texera-helmchart/templates/access-control-service-deployment.yaml:
##########
@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Do we have to include these YAML files in this PR?
##########
core/access-control-service/src/main/scala/edu/uci/ics/texera/service/resource/AccessControlResource.scala:
##########
@@ -115,18 +118,18 @@ class AccessControlResource extends LazyLogging {
@GET
@Path("/{path:.*}")
def authorizeGet(
- @Context uriInfo: UriInfo,
- @Context headers: HttpHeaders
- ): Response = {
+ @Context uriInfo: UriInfo,
+ @Context headers: HttpHeaders
+ ): Response = {
AccessControlResource.authorize(uriInfo, headers)
}
@POST
@Path("/{path:.*}")
def authorizePost(
- @Context uriInfo: UriInfo,
- @Context headers: HttpHeaders
- ): Response = {
+ @Context uriInfo: UriInfo,
Review Comment:
Why do you include these format changes?
##########
core/access-control-service/src/main/scala/edu/uci/ics/texera/service/resource/AccessControlResource.scala:
##########
@@ -38,11 +38,11 @@ object AccessControlResource extends LazyLogging {
/**
* Authorize the request based on the path and headers.
- * @param uriInfo URI sent by Envoy or API Gateway
- * @param headers HTTP headers sent by Envoy or API Gateway which include
- * headers sent by the client (browser)
- * @return HTTP Response with appropriate status code and headers
- */
+ * @param uriInfo URI sent by Envoy or API Gateway
Review Comment:
These format changes shouldn't be in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
