aglinxinyuan commented on PR #3753: URL: https://github.com/apache/texera/pull/3753#issuecomment-3413740537
> > > @aglinxinyuan Can we add test cases? > > > > > > We don't need to add new test cases for the following reason: > > > > > > 1. This PR doesn’t introduce any new components — the functionality it affects is already covered by existing test cases. > > > 2. The main change in this PR is a visual update on the front end, and our current testing framework doesn’t support GUI testing. Even if we used a framework that can test GUIs, defining the “correctness” of a visual element would still be difficult. For example, if a region’s shape is 10 px larger than expected due to differences in library algorithms, it would still be considered valid. > > > > I disagree. There are new code, there better be new tests. Try use AI to generate tests? At least you can test if this new component can be initialized properly. We have quite a few frontend test cases written in the way you described. Honestly, i don't like this approach—because in doing so, we’re essentially adding test cases just for the sake of having test cases. If we can’t find a meaningful way to verify a component’s functionality, then we’re just creating tests that will never fail and can’t actually catch any bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
