xuang7 commented on code in PR #3906:
URL: https://github.com/apache/texera/pull/3906#discussion_r2433997637
##########
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.html:
##########
@@ -206,206 +206,208 @@ <h3 class="file-title">
nzTheme="outline"></i>
</div>
</nz-resize-handle>
- <div class="right-sider">
- <nz-collapse nzGhost>
- <nz-collapse-panel
- nzHeader="Current Versions"
- nzActive="true">
- <div class="version-storage">
- <h6 style="font-weight: lighter; font-size: 0.9em">Choose a
Version:</h6>
- <div class="select-and-button-container">
- <nz-select
- nzShowSearch
- nzAllowClear
- nzPlaceHolder="Select a version"
- (ngModelChange)="onVersionSelected($event)"
- [(ngModel)]="selectedVersion">
- <nz-option
- *ngFor="let version of versions"
- [nzValue]="version"
- [nzLabel]="version.name"></nz-option>
- </nz-select>
- <button
- nz-button
- nz-tooltip="Download Dataset"
- (click)="onClickDownloadVersionAsZip()"
- *ngIf="selectedVersion"
- [disabled]="!isLogin || !isDownloadAllowed()"
- class="spaced-button">
- <i
- nz-icon
- nzType="download"
- nzTheme="outline"></i>
- </button>
- </div>
- <ng-container *ngIf="selectedVersion">
- <div class="version-size">
- <i
- nz-icon
- nzType="database"
- nzTheme="outline"
- class="icon-database"></i>
- Version Size: {{ formatSize(currentDatasetVersionSize) }}
- </div>
- <div
- *ngIf="selectedVersionCreationTime"
- class="version-date">
- <i
- nz-icon
- nzType="calendar"
- nzTheme="outline"
- class="icon-database"></i>
- Created at: {{ selectedVersionCreationTime }}
+ <div class="right-sider-scrolling-container">
+ <div class="right-sider">
Review Comment:
I noticed that the "right-sider" currently has no styles. Could we avoid the
extra wrapper "right-sider-scrolling-container" by applying the scrolling
styles directly to the existing element?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
