aicam commented on code in PR #3756: URL: https://github.com/apache/texera/pull/3756#discussion_r2409179510
########## deployment/single-node/.env: ########## @@ -28,31 +28,44 @@ LAKEFS_INSTALLATION_ACCESS_KEY_ID=AKIAIOSFOLKFSSAMPLES LAKEFS_INSTALLATION_SECRET_ACCESS_KEY=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY LAKEFS_BLOCKSTORE_TYPE=s3 LAKEFS_BLOCKSTORE_S3_FORCE_PATH_STYLE=true -LAKEFS_BLOCKSTORE_S3_ENDPOINT=http://texera-minio:9000 +LAKEFS_BLOCKSTORE_S3_ENDPOINT=http://minio:9000 LAKEFS_BLOCKSTORE_S3_CREDENTIALS_ACCESS_KEY_ID=texera_minio LAKEFS_BLOCKSTORE_S3_CREDENTIALS_SECRET_ACCESS_KEY=password LAKEFS_AUTH_ENCRYPT_SECRET_KEY=random_string_for_lakefs LAKEFS_LOGGING_LEVEL=INFO LAKEFS_STATS_ENABLED=1 LAKEFS_DATABASE_TYPE=postgres -LAKEFS_DATABASE_POSTGRES_CONNECTION_STRING=postgres://texera:password@texera-postgres:5432/texera_lakefs?sslmode=disable +LAKEFS_DATABASE_POSTGRES_CONNECTION_STRING=postgres://texera:password@postgres:5432/texera_lakefs?sslmode=disable Review Comment: Why do we need to remove `texera` from all variables? ########## deployment/single-node/.env: ########## @@ -28,31 +28,44 @@ LAKEFS_INSTALLATION_ACCESS_KEY_ID=AKIAIOSFOLKFSSAMPLES LAKEFS_INSTALLATION_SECRET_ACCESS_KEY=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY LAKEFS_BLOCKSTORE_TYPE=s3 LAKEFS_BLOCKSTORE_S3_FORCE_PATH_STYLE=true -LAKEFS_BLOCKSTORE_S3_ENDPOINT=http://texera-minio:9000 +LAKEFS_BLOCKSTORE_S3_ENDPOINT=http://minio:9000 LAKEFS_BLOCKSTORE_S3_CREDENTIALS_ACCESS_KEY_ID=texera_minio LAKEFS_BLOCKSTORE_S3_CREDENTIALS_SECRET_ACCESS_KEY=password LAKEFS_AUTH_ENCRYPT_SECRET_KEY=random_string_for_lakefs LAKEFS_LOGGING_LEVEL=INFO LAKEFS_STATS_ENABLED=1 LAKEFS_DATABASE_TYPE=postgres -LAKEFS_DATABASE_POSTGRES_CONNECTION_STRING=postgres://texera:password@texera-postgres:5432/texera_lakefs?sslmode=disable +LAKEFS_DATABASE_POSTGRES_CONNECTION_STRING=postgres://texera:password@postgres:5432/texera_lakefs?sslmode=disable -STORAGE_S3_ENDPOINT=http://texera-minio:9000 -STORAGE_LAKEFS_ENDPOINT=http://texera-lakefs:8000/api/v1 -STORAGE_JDBC_URL=jdbc:postgresql://texera-postgres:5432/texera_db?currentSchema=texera_db,public +STORAGE_S3_ENDPOINT=http://minio:9000 +STORAGE_LAKEFS_ENDPOINT=http://lakefs:8000/api/v1 +STORAGE_JDBC_URL=jdbc:postgresql://postgres:5432/texera_db?currentSchema=texera_db,public STORAGE_JDBC_USERNAME=texera STORAGE_JDBC_PASSWORD=password -FILE_SERVICE_GET_PRESIGNED_URL_ENDPOINT=http://texera-file-service:9092/api/dataset/presign-download -FILE_SERVICE_UPLOAD_ONE_FILE_TO_DATASET_ENDPOINT=http://texera-file-service:9092/api/dataset/did/upload +FILE_SERVICE_GET_PRESIGNED_URL_ENDPOINT=http://file-service:9092/api/dataset/presign-download +FILE_SERVICE_UPLOAD_ONE_FILE_TO_DATASET_ENDPOINT=http://file-service:9092/api/dataset/did/upload USER_SYS_ENABLED=true STORAGE_ICEBERG_CATALOG_TYPE=postgres -STORAGE_ICEBERG_CATALOG_POSTGRES_URI_WITHOUT_SCHEME=texera-postgres:5432/texera_iceberg_catalog +STORAGE_ICEBERG_CATALOG_POSTGRES_URI_WITHOUT_SCHEME=postgres:5432/texera_iceberg_catalog STORAGE_ICEBERG_CATALOG_POSTGRES_USERNAME=texera STORAGE_ICEBERG_CATALOG_POSTGRES_PASSWORD=password +# variables for admin user credentials +USER_SYS_ADMIN_USERNAME=texera +USER_SYS_ADMIN_PASSWORD=texera # variables for example user, datasets and workflows -TEXERA_EXAMPLE_USERNAME=texera -TEXERA_EXAMPLE_PASSWORD=texera +TEXERA_EXAMPLE_USERNAME="${USER_SYS_ADMIN_USERNAME}" Review Comment: I think the env should have examples and docker compose override them, here you are using system env inside `.env` file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
