jaeyun0503 commented on PR #3913: URL: https://github.com/apache/texera/pull/3913#issuecomment-3413192585
> LGTM in general, but the code in this PR looks significantly different from what I remembered in #3827. Somehow all the code in that original PR is deleted though. > > In the original PR I remember you extracted the logic for validating the parameters and the logic for generating the chart as separate Scala methods. Also the chart was not generated using Plotly Express. This PR seems to be a new implementation. > > Given that this is a new implementation, I suggest @jaeyun0503 also do another round of review (and do some testing if possible.) Got it. I will look into it tonight and review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
