GitHub user mengw15 edited a comment on the discussion: Merge the Python Notebook Migration Tool in a Single PR
Thanks @kunwp1 for the input. In general I agree a large PR isn't ideal, and smaller PRs are better when feasible. To address @zyratlo's concern about keeping the tool fully functional at each step, I wonder if we could keep @kunwp1's three slices but reorder them: PR1: Uploading + LLM notebook-to-workflow conversion — the core function. After this PR, a user can upload a notebook and get a converted workflow end-to-end. PR2: Rendering the notebook (plus window controls) — adds the Jupyter iframe panel as a UX enhancement on top of the working tool. PR3: Cell-to-operator mapping — adds traceability between cells and operators. Under this ordering, the main functionality lands in PR1, and PR2/PR3 are additive features. The tool stays functional after every PR, so the slices are more independent. @zyratlo — could you confirm whether this reordering is feasible given the actual code dependencies? If it isn't, I'm not against shipping as a single PR, since the code is well-isolated, the risk is low. GitHub link: https://github.com/apache/texera/discussions/4590#discussioncomment-16776757 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
