GitHub user zyratlo edited a comment on the discussion: Proposal: Ditch Angular and Switch to a new frontend framework
Thanks for putting this together. I have a few questions about JointJS, and will put other thoughts in a separate comment. Please correct me if I am misunderstanding anything. >From what I can gather, the `jointjs` npm package is deprecated because it was >renamed to `@joint/core` in v4 (Feb 2024). The library is still actively >maintained, the latest release (4.3.4) came out on Oct 27, see >https://www.npmjs.com/package/@joint/core. The license also hasn't changed, >it's MPL-2.0, the same as the 3.5 we currently use. If we already know this >and there is a reason we haven't upgraded, please correct me and the rest of >this comment is moot. The reason I bring this up is that, going by JointJS's changelog, we're missing a lot by staying on 3.5. There are security fixes, and 4.2 added viewport-based rendering options for large graphs. If the React Flow speed comparison was run against our current 3.5 setup, I don't think it tells us much about current JointJS. Another thing is that JointJS now has an official React binding, `@joint/react` (MPL-2.0, released with 4.3.0 in July, see https://www.npmjs.com/package/@joint/react). It's still new, but it means React Flow isn't the only canvas option if we do go with React. Using `@joint/react` could let us keep much of our existing JointJS code instead of rewriting the canvas from scratch, though our shapes would still need the v4 migration. So in summary, my questions are: 1. Is there a reason we can't upgrade to `@joint/core` 4.3.4? I see #5366 scoped the migration but it was closed without a PR. 2. Was the React Flow comparison done against JointJS 3.5? If so, and we can upgrade, a comparison against 4.3.4 would tell us more. 3. If we do switch to React, would you be open to evaluating `@joint/react` alongside React Flow and the other collaborative canvas libraries before we decide? GitHub link: https://github.com/apache/texera/discussions/9387#discussioncomment-19504163 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
