GitHub user dharmeshkakadia opened a pull request:

    https://github.com/apache/tez/pull/16

    Correct the downloaded ATS dag data location for analyzer

     hadoop jar /usr/hdp/current/tez-client/tez-job-analyzer-*.jar CriticalPath 
--dagId=dag_1475171170456_0002_1  --outputDir=tmp/
     fails with 
    
    INFO history.ATSImportTool: Using 
baseURL=http://headnodehost:8188/ws/v1/timeline, 
dagId=dag_1475171170456_0002_1, batchSize=100, downloadDir=tmp
    java.lang.IllegalArgumentException: Zipfile 
tmp/dag_1475171170456_0002_1/dag_1475171170456_0002_1.zip does not exist
            at 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
            at 
org.apache.tez.history.parser.ATSFileParser.<init>(ATSFileParser.java:65)
            at 
org.apache.tez.analyzer.plugins.TezAnalyzerBase.run(TezAnalyzerBase.java:169)
            at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
            at 
org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.main(CriticalPathAnalyzer.java:653)
    
    
    The code is incorrectly expecting it to be in 
subfolder(dag_1475171170456_0002_1/dag_1475171170456_0002_1.zip). Moving the 
downloaded data location to the subfolder fixes the issue. This PR corrects the 
expected path.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dharmeshkakadia/tez patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tez/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit 7360f801611c018288a3db73b764d217bfe4c2b1
Author: Dharmesh Kakadia <[email protected]>
Date:   2016-09-29T21:22:24Z

    Correct the downloaded ATS dag data location for analyzer
    
     hadoop jar /usr/hdp/current/tez-client/tez-job-analyzer-*.jar CriticalPath 
--dagId=dag_1475171170456_0002_1  --outputDir=tmp/
     fails with 
    
    INFO history.ATSImportTool: Using 
baseURL=http://headnodehost:8188/ws/v1/timeline, 
dagId=dag_1475171170456_0002_1, batchSize=100, downloadDir=tmp
    java.lang.IllegalArgumentException: Zipfile 
tmp/dag_1475171170456_0002_1/dag_1475171170456_0002_1.zip does not exist
            at 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
            at 
org.apache.tez.history.parser.ATSFileParser.<init>(ATSFileParser.java:65)
            at 
org.apache.tez.analyzer.plugins.TezAnalyzerBase.run(TezAnalyzerBase.java:169)
            at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
            at 
org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.main(CriticalPathAnalyzer.java:653)
    
    
    The code is incorrectly expecting it to be in 
subfolder(dag_1475171170456_0002_1/dag_1475171170456_0002_1.zip). Moving the 
downloaded data location to the subfolder fixes the issue. This PR corrects the 
expected path.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to