Github user beltran commented on a diff in the pull request:
https://github.com/apache/tez/pull/33#discussion_r232032540
--- Diff: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java ---
@@ -2440,23 +2453,30 @@ public void run() {
}
}
- private void startDAG() throws IOException, TezException {
+ private boolean hasConcurrentEdge(DAGPlan dagPlan) {
+ boolean hasConcurrentEdge = false;
+ for (DAGProtos.EdgePlan edge : dagPlan.getEdgeList()) {
+ if
(DAGProtos.PlanEdgeSchedulingType.CONCURRENT.equals(edge.getSchedulingType())) {
+ return true;
+ }
+ }
+ return hasConcurrentEdge;
+ }
+
+ private DAGPlan readDAGPlanFile() throws IOException, TezException {
FileInputStream dagPBBinaryStream = null;
+ DAGPlan dagPlan = null;
try {
- DAGPlan dagPlan = null;
-
// Read the protobuf DAG
dagPBBinaryStream = new FileInputStream(new File(workingDirectory,
TezConstants.TEZ_PB_PLAN_BINARY_NAME));
dagPlan = DAGPlan.parseFrom(dagPBBinaryStream);
-
- startDAG(dagPlan, null);
--- End diff --
I see this has been moved
[here](https://github.com/apache/tez/pull/33/files#diff-755c0ec043a1800cd6cbf31823a59c8fR2069).
Are there going to be any consequences with that? The logic is not exactly the
same since before `startDAG(dagPlan, null);` is called as long as
`(!isSession)` and now it wouldn't if it gets in the section `if
(recoveredDAGData != null) {` in `DAGAppMaster.serviceStart`
---
