jteagles commented on a change in pull request #37: TEZ-4042: Speculative attempts should avoid running on the same node URL: https://github.com/apache/tez/pull/37#discussion_r259216152
########## File path: tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/TaskAttemptImpl.java ########## @@ -228,6 +228,7 @@ public static DataEventDependencyInfo fromProto(DataEventDependencyInfoProto pro private final boolean leafVertex; private TezTaskAttemptID creationCausalTA; + private Set<NodeId> unhealthyNodesHistory; Review comment: From a design perspective, I wonder if the task attempt owns the list of nodes to avoid. Really this data structure is owned by the Task and used by the Task Attempt. Unfortunately, it seems TaskAttemptImpl doesn't have its own Task like getTask(). Then we could move the logic of avoidance to TaskImpl. This is probably acceptable as is, but it points to needing some refactoring of this class in the future. So I don't think a change should be made as part of this jira. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
