Chyler commented on a change in pull request #37: TEZ-4042: Speculative
attempts should avoid running on the same node
URL: https://github.com/apache/tez/pull/37#discussion_r259385780
##########
File path:
tez-dag/src/main/java/org/apache/tez/dag/app/rm/DagAwareYarnTaskScheduler.java
##########
@@ -567,8 +568,9 @@ private void informAppAboutAssignments(List<Assignment>
assignments) {
* @param container the container assigned to the task
*/
private void informAppAboutAssignment(TaskRequest request, Container
container) {
- if (blacklistedNodes.contains(container.getNodeId())) {
- Object task = request.getTask();
+ Object task = request.getTask();
+ if (blacklistedNodes.contains(container.getNodeId())
+ || task instanceof TaskAttempt && ((TaskAttempt)
task).getUnhealthyNodesHistory().contains(container.getNodeId())) {
Review comment:
Good point, I have shifted the checking earlier when deciding on
"canAssignTaskToContainer", and do similar changes in
DagAwareYarnTaskScheduler too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
