belugabehr commented on a change in pull request #90:
URL: https://github.com/apache/tez/pull/90#discussion_r563394232
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -2269,15 +2261,6 @@ public void handle(VertexEvent event) {
}
}
- private static void validateInputParam(String value, String param)
Review comment:
One used in one place. Limited value,
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -2269,15 +2261,6 @@ public void handle(VertexEvent event) {
}
}
- private static void validateInputParam(String value, String param)
Review comment:
Only used in one place. Limited value,
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -313,7 +311,6 @@
/**
* set of already executed dag names.
*/
- Set<String> dagNames = new HashSet<String>();
Review comment:
No references to this variable anywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
