jteagles commented on pull request #26: URL: https://github.com/apache/tez/pull/26#issuecomment-776224361
@rlukin, someone else found the answer to this file inclusion problem. https://github.com/apache/tez/blob/master/tez-ui/src/main/webapp/ember-cli-build.js#L47 By modifying this from '*.env' to "*.js" this does include configs.js, however it also includes other files .//config/configs.js .//config/build-info.js .//config/environment.js .//config/default-app-conf.js Modifying from '*.env' to 'configs.js' limits the build to only include configs.js into the build. Do you feel comfortable making this change? Otherwise, we can commit this change and create a follow-up jira to address configs.js file inclusion. Personally, I feel this change below should below in this PR for clarity. ``` diff --git tez-ui/src/main/webapp/ember-cli-build.js tez-ui/src/main/webapp/ember-cli-build.js index 9b52210af..7bbc77d33 100644 --- tez-ui/src/main/webapp/ember-cli-build.js +++ tez-ui/src/main/webapp/ember-cli-build.js @@ -44,7 +44,7 @@ module.exports = function(defaults) { var configEnv = new Funnel('config', { srcDir: '/', - include: ['*.env'], + include: ['configs.js'], destDir: '/config' }); var zipWorker = new Funnel('bower_components/zip-js', { ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
