abstractdog commented on pull request #95: URL: https://github.com/apache/tez/pull/95#issuecomment-776959257
> OK @jteagles @abstractdog this PR is failing on some pre-existing find bugs error. Kind of funny actually: > > ``` > Null passed for non-null parameter of com.google.common.base.Strings.isNullOrEmpty(String) > ``` > > The method has `isNull` in the name of it, of course it can accept a null value. :D > > Please consider these changes as they should lower memory requirements, provide faster concurrent access, and simplify the code a bit. In particular, please consider my thoughts here: > > [#95 (comment)](https://github.com/apache/tez/pull/95#discussion_r572336225) yeah, absolutely, we've also found similar isNull* madness in https://issues.apache.org/jira/browse/TEZ-4215, I believe we should merge that @jteagles, and @belugabehr you can handle this in a similar way...if findbugs warning simply doesn't makes sense, let's try to ignore it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
