Stamatis Zampetakis created TEZ-4534:
----------------------------------------

             Summary: Different AL2 headers in source code
                 Key: TEZ-4534
                 URL: https://issues.apache.org/jira/browse/TEZ-4534
             Project: Apache Tez
          Issue Type: Bug
            Reporter: Stamatis Zampetakis
            Assignee: Stamatis Zampetakis


The official source header recommender by ASF can be found here: 
[https://www.apache.org/legal/src-headers.html#header-text]

The source code now contains at least two variants as outline below.

The expected one as indicated by the previous link.
{noformat}
/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
{noformat}

The following which I assume is an older recommendation from the ASF.
{noformat}
/*
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
{noformat}

Having different headers may not be a violation of the ASF policy but maybe it 
makes sense to apply the current official recommendation consistently across 
the code base. Since the header appears always at the top of the files any 
potential merge conflicts should be trivial to resolve.





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to