Auto-generated C++ code fails to compile with "-Werror -Wextra -Wall" g++
compiler flags
----------------------------------------------------------------------------------------
Key: THRIFT-1036
URL: https://issues.apache.org/jira/browse/THRIFT-1036
Project: Thrift
Issue Type: Bug
Components: C++ - Compiler
Affects Versions: 0.7
Environment: OS: FreeBSD-8.0
Compiler: g++ (GCC) 4.2.1 20070719 [FreeBSD]
Reporter: Pavlin Radoslavov
Fix For: 0.7
If the following command is used to auto-generate the C++ code
thrift --gen cpp:cob_style foo.thrift
then some of the auto-generated code contains the following:
class FooCobClient : virtual public FooCobClIf {
...
virtual void completed__(bool success) {}
...
};
The above code fails to compile if we use g++ with the "-Werror -Wextra -Wall"
compiler options:
gen-cpp/Foo.h:767: warning: unused parameter 'success'
The solution is trivial: just comment-out the unused "success" argument (see
attached patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
