[
https://issues.apache.org/jira/browse/THRIFT-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000890#comment-13000890
]
Chris Morgan commented on THRIFT-904:
-------------------------------------
I agree that we don't want nagle disabled for any implementation the issue is:
1. TSimpleServer/Client runs VERY poorly with nagle enabled
2. Previously C/Java and others disabled nagle but C# didn't.
Today we've fixed the second issue, Thrift is now uniform in how it handles
nagle for the simple case.
Now if we can make the simple server use a single packet instead of sending the
4 byte header separately then we can disable nagle for everyone again. If this
conflicts with the server being "simple" then I think we should just document
the issue, the workaround (disabling nagle), and suggest that for better
performance users should use the frame transport.
Chris
> C# TSocket should disable nagle and linger
> ------------------------------------------
>
> Key: THRIFT-904
> URL: https://issues.apache.org/jira/browse/THRIFT-904
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Reporter: Jonathan Ellis
> Assignee: Alexey Biryukov
> Fix For: 0.6
>
> Attachments: thrift-904.patch, thrift-904.tests.patch
>
>
> Java sets
> socket_.setSoLinger(false, 0);
> socket_.setTcpNoDelay(true);
> C# should do the equivalent.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
