[
https://issues.apache.org/jira/browse/THRIFT-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003516#comment-13003516
]
Henrique Mendonca commented on THRIFT-1014:
-------------------------------------------
Great job Roger, could you commit that?
It works fine for me, I still have warnings on generated files but it is
already a good improvement.
Thanks a lot,
Henrique
ps.: it will need the jsdoc comments (and annotation) for the advanced closure
compiler, but we can add this later on
> Thrift JavaScript code should use semicolon-terminated statements
> -----------------------------------------------------------------
>
> Key: THRIFT-1014
> URL: https://issues.apache.org/jira/browse/THRIFT-1014
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, JavaScript - Library
> Reporter: James Hamlin
> Priority: Minor
> Attachments: THRIFT-1014_JavaScript_lint_fixes.patch
>
>
> It's good style to terminate all JavaScript statements with a semicolon.
> Thrift's JavaScript library and generated JavaScript don't use semicolons at
> all. Beyond the stylistic improvement, fixing up the syntax would make
> Thrift's JavaScript compatible with certain JavaScript linters, e.g. Google
> Closure's.
> I have a patch that's about ready if the project will take contributions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
