Incorrent comment for listen method in TServerSocket and 
TNonblockingServerSocket
---------------------------------------------------------------------------------

                 Key: THRIFT-1118
                 URL: https://issues.apache.org/jira/browse/THRIFT-1118
             Project: Thrift
          Issue Type: Improvement
          Components: Java - Library
    Affects Versions: 0.6
            Reporter: Jingguo Yao
            Priority: Minor


For the listen method in TServerSocket and TNonblockingServerSocket, there is 
the comment "Make sure not to block on accept". Following this comment, there 
is the statement "serverSocket_.setSoTimeout(0)". But setSoTimeout's 
[javadoc|http://download.oracle.com/javase/6/docs/api/java/net/ServerSocket.html#setSoTimeout(int)]
 says "A timeout of zero is interpreted as an infinite timeout." So the comment 
should be "Make sure to block on accept". 


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to