[ 
https://issues.apache.org/jira/browse/THRIFT-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicholas Telford resolved THRIFT-1052.
--------------------------------------

    Resolution: Cannot Reproduce

I'm able to compile the extension in trunk and in 0.6 without issues.

I had a look at the offending line (416) and I can't seem to find the token 
allegedly causing issues so I can only surmise that it's changed enough that 
this issue is no longer valid.

If you still have issues compiling the extension (from trunk, preferably), 
please open a new ticket.

> Failed to compile Thrift 0.5 with php extension
> -----------------------------------------------
>
>                 Key: THRIFT-1052
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1052
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.5
>         Environment: Fedora 14 with GCC 4.5.1
>            Reporter: Koala Yeung
>
> I tried to compile Thrift 0.5 with the following config parameters:
> ./configure \
>   --prefix="/usr/local/thrift-20110106" \
>   --with-csharp=no \
>   --with-java=no \
>   --with-erlang=no \
>   --with-python=no \
>   --with-php=yes \
>   --with-php_extension=yes \
>   --with-ruby=no \
>   --with-haskell=no
> Seems GCC 4.5.1 fail to compile the file 
> "./lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp"
> This is the relevant compile output:
> -------------------------------
> ...
> ...
> /bin/sh 
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/libtool 
> --mode=compile g++  -I. 
> -I/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol 
> -DPHP_ATOM_INC 
> -I/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/include 
> -I/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/main 
> -I/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol 
> -I/usr/local/php-5.3.1/include/php -I/usr/local/php-5.3.1/include/php/main 
> -I/usr/local/php-5.3.1/include/php/TSRM 
> -I/usr/local/php-5.3.1/include/php/Zend 
> -I/usr/local/php-5.3.1/include/php/ext 
> -I/usr/local/php-5.3.1/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c 
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
>  -o php_thrift_protocol.lo
> mkdir .libs
>  g++ -I. -I/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol 
> -DPHP_ATOM_INC 
> -I/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/include 
> -I/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/main 
> -I/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol 
> -I/usr/local/php-5.3.1/include/php -I/usr/local/php-5.3.1/include/php/main 
> -I/usr/local/php-5.3.1/include/php/TSRM 
> -I/usr/local/php-5.3.1/include/php/Zend 
> -I/usr/local/php-5.3.1/include/php/ext 
> -I/usr/local/php-5.3.1/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c 
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
>   -fPIC -DPIC -o .libs/php_thrift_protocol.o
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:103:1:
>  warning: deprecated conversion from string constant to 'char*
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:
>  In function 'void throw_tprotocolexception(char*, long int)
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:408:62:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:
>  In function 'void throw_zend_exception_from_std_exception(const 
> std::exception&)':
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:416:51:
>  error: expected primary-expression before ',' tok
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:416:51:
>  error: 'tsrm_ls' was not declared in this scope
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:
>  In function 'void binary_deserialize(int8_t, PHPInputTransport&, zval*, 
> HashTable*)':
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:431:71:
>  warning: deprecated conversion from string constant to 'char*
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:443:120:
>  warning: deprecated conversion from string constant to 'char*
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:
>  In function 'void binary_serialize(int8_t, PHPOutputTransport&, zval**, 
> HashTable*)':
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:734:95:
>  warning: deprecated conversion from string constant to 'char*
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:736:114:
>  warning: deprecated conversion from string constant to 'char*
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:738:97:
>  warning: deprecated conversion from string constant to 'char*
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:782:106:
>  warning: deprecated conversion from string constant to 'char*
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:809:107:
>  warning: deprecated conversion from string constant to 'char*
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:831:106:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:
>  In function 'void binary_serialize_spec(zval*, PHPOutputTransport&, 
> HashTable*)':
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:864:86:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:
>  In function 'void zif_thrift_protocol_write_binary(int, zval*, zval**, 
> zval*, int, void**)':
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:940:120:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:942:83:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:
>  In function 'void zif_thrift_protocol_read_binary(int, zval*, zval**, zval*, 
> int, void**)':
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:993:71:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:1001:109:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:1013:47:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:1014:110:
>  warning: deprecated conversion from string constant to 'char*'
> /usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp:1020:118:
>  warning: deprecated conversion from string constant to 'char*'
> make[4]: *** [php_thrift_protocol.lo] Error 1
> make[4]: Leaving directory 
> `/usr/local/src/thrift/thrift-0.5.0/lib/php/src/ext/thrift_protocol'
> make[3]: *** [src/ext/thrift_protocol/modules/thrift_protocol.so] Error 2
> make[3]: Leaving directory `/usr/local/src/thrift/thrift-0.5.0/lib/php'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/usr/local/src/thrift/thrift-0.5.0/lib'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/usr/local/src/thrift/thrift-0.5.0'
> make: *** [all] Error 2

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to