[ 
https://issues.apache.org/jira/browse/THRIFT-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019493#comment-13019493
 ] 

Torben Brodt commented on THRIFT-1144:
--------------------------------------

Ahhh, now i know why $host and $port are the only protected variables in 
TSocket ;)
I think they were changed to protected because somebody wanted to access it 
from the subclass "TSocketPool".

For reconnect of persistent variables, i need $persist_ to be protected. But 
should i only change this variable? For maximum flexibility i would recommend 
to change all the variables.

Short description of my TSocket issue
A feew times per day i get a timeout. That's ok. But all future calls from this 
apache single process will have timeouts too - other apache process work fine. 
Currently I restart apache after monitoring the logfiles. My next approach is 
to refresh the persistent connection. But i will go deeper into this later and 
will create an issue report later when i know if its php/apache specific or 
thrift.

> Attributes from private to protected
> ------------------------------------
>
>                 Key: THRIFT-1144
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1144
>             Project: Thrift
>          Issue Type: Wish
>          Components: PHP - Library
>    Affects Versions: 0.7
>            Reporter: Torben Brodt
>              Labels: inheritance, private, protected
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> I would like to change all attributes from private to protected.
> Cause of a bug in TSocket i wanted to inherit from this class to add a 
> reconnect for persistent connection, but since all of the member variables 
> were private i couldn't archieve that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to