[ 
https://issues.apache.org/jira/browse/THRIFT-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078514#comment-13078514
 ] 

Hudson commented on THRIFT-1255:
--------------------------------

Integrated in Thrift #208 (See [https://builds.apache.org/job/Thrift/208/])
    THRIFT-1255. javame: Mismatch of method name between JavaME's lib and 
generated code (compareTo/compareObjects)

Patch: Raphael Bartement

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1153295
Files : 
* /thrift/trunk/lib/javame/src/org/apache/thrift/TBaseHelper.java


> Mismatch of method name between JavaME's lib and generated code 
> (compareTo/compareObjects)
> ------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1255
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaME - Compiler, JavaME - Library
>    Affects Versions: 0.6.1
>            Reporter: Raphaël Bartement
>            Assignee: Raphaël Bartement
>             Fix For: 0.7
>
>         Attachments: Patch.patch
>
>
> Generated code always calls TBaseHelper.compareTo in implementations of 
> compareTo for the DTO.
> In javame's lib, there is a static utility method called 
> TBaseHelper.compareTo for anything (int, short, byte, ...) but Object, which 
> has TBaseHelper.compareObjects instead.
> When a structure's field is a structure itself into thrift's contract, the 
> generated code tries to call TBaseHelper.compareTo instead of 
> TBaseHelper.compareObjects.
> It's much easier to fix this in the library itself by making names uniform.
> Attached patch fixes this issue by renaming compareObjects into compareTo.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to