[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079623#comment-13079623
]
Roger Meier commented on THRIFT-916:
------------------------------------
no compiler warnings on CI! see
https://builds.apache.org/view/S-Z/view/Thrift/job/Thrift-cpp/
However adding -Werror causes another issue:
{noformat}
make[3]: Entering directory
`/home/hudson/hudson-slave/workspace/Thrift-cpp-roger/thrift/test/cpp'
Makefile:809: warning: overriding commands for target `gen-cpp/ThriftTest.cpp'
Makefile:806: warning: ignoring old commands for target `gen-cpp/ThriftTest.cpp'
g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src -Igen-cpp -I/usr/include
-Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow
-Werror -Wall -Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overflow -Werror -MT TestServer.o -MD -MP -MF .deps/TestServer.Tpo -c -o
TestServer.o `test -f 'src/TestServer.cpp' || echo './'`src/TestServer.cpp
mv -f .deps/TestServer.Tpo .deps/TestServer.Po
make[3]: *** No rule to make target `../../lib/cpp/libthriftnb.la', needed by
`TestServer'. Stop.
{noformat}
> gcc warnings in c++ header files
> --------------------------------
>
> Key: THRIFT-916
> URL: https://issues.apache.org/jira/browse/THRIFT-916
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.4
> Reporter: Piotr Bartosiewicz
> Assignee: Roger Meier
> Attachments: DebianLenny_error.log,
> THRIFT-916_Wall_Wextra__NOWARNINGS_DebianLenny.patch,
> THRIFT-916_Wall_Wextra_pedantic_Wno-long-long_Wno-variadic-macros_Wno-overflow_NOWARNINGS_DebianLenny.patch,
> THRIFT-916_Wall_pedantic__noerrors.patch, THRIFT-916_fix_no-overflow.patch,
> make-k.log, v1-enable-wall-werror.patch, v1-fix-format-strings.patch,
> v1-fix-java-style-and-warnings.patch, v1-fix-more-warnings.patch,
> v1-fix-random-silly-warnings.patch, v1-long-long-to-int64_t.patch,
> v2-enable-wall-werror.patch, v2-fix-all-warnings.patch,
> v3-enable-wall-werror.patch, v3-fix-all-warnings.patch,
> v4-enable-wall-werror.patch, v4-fix-all-warnings.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of
> warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall
> -Wextra -pedantic" options.
> Currently only with -Wall thrift has no warnings.
> Other options worth considering (but require more work) are -Wconversion
> -Wold-style-cast
> So the task is to improve the thrift headers.
> I suggest also update all the thrift makefiles so the thrift sources an tests
> will indicate the faulty code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
