TSocketClient is queried by run loop after deallocation
-------------------------------------------------------
Key: THRIFT-1264
URL: https://issues.apache.org/jira/browse/THRIFT-1264
Project: Thrift
Issue Type: Bug
Components: Cocoa - Library
Affects Versions: 0.7
Environment: iPad, iOS SDK 4.3
Reporter: Jan Rüth
Priority: Critical
When using TSocketClient in a Cocoa client and correctly managing the memory:
{code:title=Server.m|borderStyle=solid}
- (id)initWithServer:(NSString*)server port:(NSInteger)port
{
self = [super init];
if (self) {
TSocketClient *transport = [[TSocketClient alloc]
initWithHostname:server
port:port];
TBinaryProtocol *protocol = [[TBinaryProtocolFactory sharedFactory]
newProtocolOnTransport:transport];
Client *client = [[Client alloc] initWithProtocol:protocol];
// self.client is a retained property
self.client = client;
[client release];
[protocol release];
[transport release];
}
return self;
}
- (void)dealloc {
self.client = nil;
[super dealloc];
}
{code}
(maybe this should be fixed in the cocoa example, memory management is
erroneous there)
After successfully releasing the object with the code above. One gets a
EXC_BAD_ACCESS signal because the runloop send a responseToSelector: message to
our object. With the selector stream:handleEvent:
This all leads to TSocketClient which opens two NSStream objects and delegates
it self to both, afterwards both Streams are scheduled in the runloop, which
should actually notify the delegate when something happens to the stream like
data is available, this obviously results in the runloop asking TSocketClient
for previously described selector. However this mechanism is not used, the
TNSStreamTransport class is subclassed and responsible for read/write.
So why are the Streams schedules in the run loop in the first place?
Why are the streams not closed and released when the object gets deallocated?
I could fix this behavior by implementing a dealloc method in TSocketClient and
making the Streams member variables
{code:title=TSocketClient.h|borderStyle=solid}
@interface TSocketClient : TNSStreamTransport {
NSInputStream * inputStream;
NSOutputStream * outputStream;
}
{code}
{code:title=TSocketClient.m|borderStyle=solid}
-(void)dealloc {
[inputStream close];
[outputStream close];
[inputStream release];
[outputStream release];
[super dealloc];
}
{code}
However I still don't know if that is the right way.
Suggestions?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
