[
https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089710#comment-13089710
]
Paul Querna commented on THRIFT-1267:
-------------------------------------
+1 to incompatible change to use the node.js style of callback(err, result);
All of our existing code uses this style, and it is essential when dealing with
async handlers in a service.
> Node.js can't throw exceptions.
> --------------------------------
>
> Key: THRIFT-1267
> URL: https://issues.apache.org/jira/browse/THRIFT-1267
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: compiler, javascript, node, nodejs
> Fix For: 0.8
>
> Attachments: nodejs-exception.patch
>
>
> There is no way as far as I can tell for node.js servers to throw thrift
> exceptions.
> I have made a patch to allow it to throw exceptions. It lets the node.js
> server implementation give params directly to the result object, thereby
> being able to specify the exception. It doesn't affect normal (non exception)
> return data.
> Test case: https://gist.github.com/1151782
> Install thrift module "npm install thrift", generate thrift "thrift --gen
> js:node test.thrift" and run server then client.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
