[
https://issues.apache.org/jira/browse/THRIFT-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1330.
--------------------------------
Resolution: Not A Problem
Assignee: Jake Farrell
the compiler was given a 'namespace' option to not break compatibility with
older versions of php. From thrift --help
namespace: Generate PHP namespaces as defined in PHP >= 5.3
> thrift --gen php:namespace test.thrift
> grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" ||
> echo "NO NAMESPACE FOUND"
namespace TestNamespace;
Has namespace
> PHP Namespaces no longer generated
> ----------------------------------
>
> Key: THRIFT-1330
> URL: https://issues.apache.org/jira/browse/THRIFT-1330
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
> Affects Versions: 0.7, 0.8
> Environment: Mac OS X 10.6.8, CentOS 5.6, Ubuntu 11.04
> Reporter: B Armstrong
> Assignee: Jake Farrell
> Priority: Critical
>
> PHP namespaces are not being generated, ever. PHP 5.3 namespace aren't
> generated either.
> The following will illustrate the bug. This works in Thrift 0.6.*
> $ thrift -version
> Thrift version 0.7.0
> $ cat > test.thrift
> namespace php TestNamespace
> struct ItemX {}
> $ thrift --gen php test.thrift
> $ grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" ||
> echo "NO NAMESPACE FOUND"
> NO NAMESPACE FOUND
> $ thrift -version
> Thrift version 0.8.0-dev
> $ thrift -gen php test.thrift
> $ grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" ||
> echo "NO NAMESPACE FOUND"
> NO NAMESPACE FOUND
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
