[
https://issues.apache.org/jira/browse/THRIFT-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Verdoïa Laurent updated THRIFT-1386:
------------------------------------
Attachment: toString.patch
The patch
> The toString function can consume less CPU and tests
> ----------------------------------------------------
>
> Key: THRIFT-1386
> URL: https://issues.apache.org/jira/browse/THRIFT-1386
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler
> Affects Versions: 0.8
> Reporter: Verdoïa Laurent
> Priority: Minor
> Fix For: 0.8
>
> Attachments: toString.patch
>
>
> The toString member of generates classes don't need:
> 1. to test the isFirst value.
> The compiler allready know it and can handle the last comma himself
> 2. to handle special case for nullable object.
> StrinBuilder is used for create the resulting string.
> This append method always append the string "null" for null objects.
> But the result of append(char[] data) with null is not specified; who care.
> We don't use it!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
