[ 
https://issues.apache.org/jira/browse/THRIFT-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131405#comment-13131405
 ] 

Kenjiro Fukumitsu edited comment on THRIFT-1397 at 10/20/11 7:13 AM:
---------------------------------------------------------------------

I uploaded a patch.
THRIFT-1397_fix_unused_parameters.zip

* This patch will fix compile error caused by unused parameter.
* This also fix one ploblem regarding exception fields.

I confirmed this patch with additional  -Werror -Wextra flag.

                
      was (Author: kenjiro):
    
I uploaded a patch.
THRIFT-1397_fix_unused_parameters.zip

* This patch will fix compile error caused by unused parameter.
* This also fix one ploblem regarding exception fields.

I confirmed this patch with additional -Wextra flag.

                  
> CI server fails during build due to unused parameters in delphi generator
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-1397
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1397
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jake Farrell
>            Priority: Blocker
>         Attachments: THRIFT-1397_fix_unused_parameters.zip
>
>
> CI server fails during build due to unused parameters in delphi generator
> src/generate/t_delphi_generator.cc:229: error: unused parameter 
> 'b_exception_method'
> src/generate/t_delphi_generator.cc:696: error: unused parameter 'value'
> src/generate/t_delphi_generator.cc:700: error: unused parameter 'value'
> src/generate/t_delphi_generator.cc:724: error: unused parameter 'cls_nm'
> src/generate/t_delphi_generator.cc:728: error: unused parameter 'out'
> src/generate/t_delphi_generator.cc:728: error: unused parameter 'name'
> src/generate/t_delphi_generator.cc:728: error: unused parameter 'type'
> src/generate/t_delphi_generator.cc:728: error: unused parameter 'value'
> src/generate/t_delphi_generator.cc:728: error: unused parameter 'cls_nm'
> src/generate/t_delphi_generator.cc:731: error: unused parameter 'name'
> src/generate/t_delphi_generator.cc:1866: error: unused parameter 'local_vars'
> src/generate/t_delphi_generator.cc:1959: error: unused parameter 'isPublic'
> src/generate/t_delphi_generator.cc: In member function 'std::string 
> t_delphi_generator::normalize_clsnm(std::string, std::string, bool)':
> src/generate/t_delphi_generator.cc:1977: error: comparison of unsigned 
> expression >= 0 is always true
> src/generate/t_delphi_generator.cc: At global scope:
> src/generate/t_delphi_generator.cc:2087: error: unused parameter 'init'
> src/generate/t_delphi_generator.cc:2233: error: unused parameter 'type'
> src/generate/t_delphi_generator.cc:2251: error: unused parameter 'type'
> src/generate/t_delphi_generator.cc:2263: error: unused parameter 'type'
> src/generate/t_delphi_generator.cc:2273: error: unused parameter 'cls_prefix'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to