[
https://issues.apache.org/jira/browse/THRIFT-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168631#comment-13168631
]
Mike Riley commented on THRIFT-1430:
------------------------------------
Since 1340 was applied this patch isn't really right anymore, so it's more than
rebasing the changes I think.
I'll just re-do it tonight or tomorrow.
A quick glance at some of my sources seems to indicate that warnings are only
generated for non-ARC files now. Are you seeing them somewhere?
> Fixes for property warnings generated in struct headers
> -------------------------------------------------------
>
> Key: THRIFT-1430
> URL: https://issues.apache.org/jira/browse/THRIFT-1430
> Project: Thrift
> Issue Type: Improvement
> Components: Cocoa - Compiler
> Affects Versions: 0.7
> Reporter: Mike Riley
> Priority: Trivial
> Attachments: thrift-1430.patch
>
>
> Every struct generates warnings in the header because the properties are
> declared twice, once implicitly through the property declaration and once
> explicitly by the actual function declarations. This was done to increase
> compatibility with older versions of objective c that didn't have the ability
> to use the property syntax as it is declared now. This is harmless but you
> get two warnings per struct member, and in my case that worked out to a few
> hundred warnings.
> The fix here is a simple refactor for isSet method declaration, and placing
> the declaration of the alternate getter/setter implementations into an #else
> statement beneath the currently existing #if statement, as opposed to just
> declaring them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
