[
https://issues.apache.org/jira/browse/THRIFT-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peace C updated THRIFT-1490:
----------------------------
Attachment: WindowsHeaders.patch
@Roger - Unix EOL for you :)
> Windows-specific header files - fixes & tweaks
> ----------------------------------------------
>
> Key: THRIFT-1490
> URL: https://issues.apache.org/jira/browse/THRIFT-1490
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Windows Visual Studio 2010
> Reporter: Peace C
> Priority: Minor
> Labels: c++, thrift, vs2010, windows
> Fix For: 0.9
>
> Attachments: WindowsHeaders.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> This patch fixes some minor issues with the Windows config.h and
> TargetVersion.h files.
> TargetVersion.h:
> _WIN32_WINNT (and thus WINVER) was being forced to 0x0601, overriding
> project-specific settings. The generally accepted approach is to let the
> project set this and only define it if it's not already present.
> config.h:
> struct pollfd must be defined for a true XP compatible build (WINVER 0x501).
> This could not happen before when WINVER was being forced to 0x0601, causing
> the struct definition to be pulled in from a Vista+ header.
> Some other tweaks resolve compiler warnings.
> I've tested this by building the Thrift C++ libraries with VS2010, as well as
> our Windows projects that use Thrift. Please provide feedback if this causes
> any issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
