[ 
https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191848#comment-13191848
 ] 

Andrew Grumet commented on THRIFT-1478:
---------------------------------------

OK.  I've patched a clean checkout and run the tests without errors.
{code}

lib/php/test$ make stubs
mkdir -p ../src/packages
../../../compiler/cpp/thrift --gen php -r --out ../src/packages 
../../../test/ThriftTest.thrift
aegrumet@ubuntu11:~/thrift/lib/php/test$ phpunit protocol/TestTJSONProtocol.php 
PHPUnit 3.6.8 by Sebastian Bergmann.

................................

Time: 2 seconds, Memory: 5.25Mb

OK (32 tests, 30 assertions)
{code}

Let me see if I can install an older version of phpunit for comparison.


                
> TJSONProtocol in PHP
> --------------------
>
>                 Key: THRIFT-1478
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1478
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>    Affects Versions: 0.8
>            Reporter: Greg Fodor
>            Assignee: Roger Meier
>            Priority: Minor
>         Attachments: THRIFT-1478.patch, THRIFT-1478.patch, THRIFT-1478.patch, 
> THRIFT-1478.patch, THRIFT-1478_incl_make_check.patch
>
>
> We needed to be able to serialize and deserialize javascript thrift calls 
> from within PHP, so I spent a few hours porting over the Java implementation 
> of TJSONProtocol to PHP. It has not been exhaustively tested but it seems to 
> be in reasonable working order. Please let me know what steps are necessary 
> to get this onto trunk. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to