[ 
https://issues.apache.org/jira/browse/THRIFT-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve White updated THRIFT-1506:
--------------------------------

    Attachment: THRIFT-1506.patch

The attached patch moves the @property declarations from 
generate_cocoa_struct_interface to 
generate_cocoa_struct_field_accessor_declarations.  It wraps them in an #if 
statement, and uses an #else to specify the getter/setter methods.  Then it 
writes out the IsSet declarations as before.
                
> Cocoa Generator shouldn't declare getter/setter methods when previously 
> declared by @property 
> ----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1506
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1506
>             Project: Thrift
>          Issue Type: Bug
>          Components: Cocoa - Compiler
>    Affects Versions: 0.8
>            Reporter: Steve White
>            Priority: Minor
>         Attachments: THRIFT-1506.patch
>
>
> The use of @property and then declaring the getter/setter methods can confuse 
> the compiler, leading to compiler errors such as:
> error: type of property 'someProperty' does not match type of accessor 
> 'setSomeProperty:'
> I would propose that based on the existing #if TARGET_OS_IPHONE || 
> (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_5) that the 
> getter/setter methods are not declared.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to