[ 
https://issues.apache.org/jira/browse/THRIFT-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204662#comment-13204662
 ] 

Hudson commented on THRIFT-556:
-------------------------------

Integrated in Thrift #402 (See [https://builds.apache.org/job/Thrift/402/])
    Thrift-556:Ruby compiler does not correctly referred to top-level modules 
when a submodule masks the top-level name
Client: rb
Patch: Ben Kelly

Prepends a :: to every  place that references the top-level module.

                
> Ruby compiler does not correctly referred to top-level modules when a 
> submodule masks the top-level name
> --------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-556
>                 URL: https://issues.apache.org/jira/browse/THRIFT-556
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Compiler
>            Reporter: Evan Weaver
>            Assignee: Ben Kelly
>             Fix For: 0.9
>
>
> Currently, if you set a top-level module for thrift/ruby that's the same name 
> as an inner class, thrift does not reference the top level appropriately. 
> Example bad code:
> .thrift:
>   namespace rb Cassandra
> .rb:
>     module Cassandra
>       module Cassandra
>         class Client
>         ...
>           COLUMN_PARENT => {:type => ::Thrift::Types::STRUCT, :name => 
> 'column_parent', :class => Cassandra::ColumnParent},
> Ruby checks the inner module first, and does not find the class, raising an 
> error. 
> The fix is to have every place that references the top-level module prepend 
> it with '::':
>           COLUMN_PARENT => {:type => ::Thrift::Types::STRUCT, :name => 
> 'column_parent', :class => ::Cassandra::ColumnParent},

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to