[
https://issues.apache.org/jira/browse/THRIFT-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251870#comment-13251870
]
Jens Geyer commented on THRIFT-1412:
------------------------------------
I have applied the third patch against my up-to-date trunk WC and now get
errors when compiling the WP7 project:
{code}
Error 1 Expected class, delegate, enum, interface, or struct
C:\D\TPCPP\S5P\3rdparty\Thrift\lib\csharp\src\Transport\THttpClient.cs 364
11 Thrift.WP7
Error 2 Expected class, delegate, enum, interface, or struct
C:\D\TPCPP\S5P\3rdparty\Thrift\lib\csharp\src\Transport\THttpClient.cs 367
22 Thrift.WP7
Error 3 Type or namespace definition, or end-of-file expected
C:\D\TPCPP\S5P\3rdparty\Thrift\lib\csharp\src\Transport\THttpClient.cs 382
2 Thrift.WP7
{code}
Seems there are two extra braces in THttpClient.cs too. If I remove them, it
compiles.
> Thrift Transport classes should manage the lifetime of objects implementing
> IDisposable by implementing IDisposable themselves.
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1412
> URL: https://issues.apache.org/jira/browse/THRIFT-1412
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
> Affects Versions: 0.7
> Reporter: Joshua Garvin
> Labels: patch
> Attachments: Thrift Transport with IDisposable.patch,
> Thrift-trunk-iDisposable v2.patch, Thrift-trunk-iDisposable.patch
>
>
> I have attached a patch to the C# Transport classes to implement IDisposable
> where needed. This will ensure that all unmanaged resources such as streams
> and sockets are properly closed and freed from memory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
