Compile thrift with php module for php 5.4.0 failed. need to replace 
function_entry with zend_function_entry
------------------------------------------------------------------------------------------------------------

                 Key: THRIFT-1577
                 URL: https://issues.apache.org/jira/browse/THRIFT-1577
             Project: Thrift
          Issue Type: Bug
          Components: PHP - Library
    Affects Versions: 0.8
         Environment: CentOS 6.2 + PHP 5.4.0
            Reporter: Matrix Ji
            Priority: Minor


As function_entry is dropped in php 5.4.0, compile thrift php-module with php 
5.4.0 failed.
zend_function_entry should be used instead, which is available from php 5.0.0

I have already create a patch for thrift-0.8.0.
{code:title=thrift-phpext.patch|borderStyle=solid}
diff -ru a/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp 
b/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
--- a/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp   2012-03-21 
08:17:30.000000000 +0800
+++ b/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp   2012-03-21 
08:18:29.000000000 +0800
@@ -92,7 +92,7 @@
 #include "zend_exceptions.h"
 #include "php_thrift_protocol.h"
 
-static function_entry thrift_protocol_functions[] = {
+static zend_function_entry thrift_protocol_functions[] = {
   PHP_FE(thrift_protocol_write_binary, NULL)
   PHP_FE(thrift_protocol_read_binary, NULL)
   {NULL, NULL, NULL}

{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to