I've uploaded a patch, which passes the unit tests for all of jquery 1.5, 1.6 and 1.7.
Notes: - I've updated the jquery version in the test page to the latest, 1.7.2. Feel free to push that back to jquery 1.5.2, or we can discuss what it would take to have multiple versions of jquery in the test suite. - The note on THRIFT-1514 describes what the patch does. The old code added an extra layer of deferreds to help with scoping issues and to mold function signatures on the callback. The patch uses another method to handle scoping, and strips out the extra layer in order to simplify things. There's a minor change to the error() callback signature, which now works like a standard ajax error callback. Interested in feedback on that. - Looking forward to getting up to speed on the node.js and require.js stuff. On Tue, Apr 17, 2012 at 3:10 AM, Paddy Byers <[email protected]> wrote: > Hi, > > One thing I had in mind is a common code base for javascript and node.js > > and use e.g. require.js => this might be a second step. > > > > Slightly related, I've been doing some work on thrift.js to: > - use native JSON support where available; and > - implement the binary protocol in the browser using ArrayBuffers. > > The native JSON protocol implementation works in nodejs and browsers with > native JSON (ie everything except IE7). It can be common-sourced if there's > a better way to generate thrift.js from a series of constituent files. I'm > currently building a thrift.js using the Google closure compiler. > > It's still early stage but if this is of general interest I can create a > patch or pull request or whatever suits. > > The code is here: > https://github.com/paddybyers/thrift/commits/0.8-aardvark-2 > > Thanks - Paddy >
