[ 
https://issues.apache.org/jira/browse/THRIFT-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264302#comment-13264302
 ] 

Hudson commented on THRIFT-1582:
--------------------------------

Integrated in Thrift #442 (See [https://builds.apache.org/job/Thrift/442/])
    THRIFT-1583 c_glib leaks memory
THRIFT-1578 C_GLib generated code does not compile
THRIFT-1582 Bad includes of nested thrift files in c_glib

Patch: José Antonio Santos
Minor Modificatons by roger:
- thrift prefix for includes
- g_object_unref instead of g_clear_object (needs glib>=2.28) (Revision 1331752)

     Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1331752
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_c_glib_generator.cc
* /thrift/trunk/lib/c_glib/test/testbinaryprotocol.c
* /thrift/trunk/lib/c_glib/test/testbufferedtransport.c
* /thrift/trunk/lib/c_glib/test/testdebugproto.c
* /thrift/trunk/lib/c_glib/test/testframedtransport.c
* /thrift/trunk/lib/c_glib/test/testmemorybuffer.c
* /thrift/trunk/lib/c_glib/test/testoptionalrequired.c
* /thrift/trunk/lib/c_glib/test/teststruct.c
* /thrift/trunk/lib/c_glib/test/testthrifttestclient.cpp
* /thrift/trunk/lib/c_glib/test/testtransportsocket.c

                
> Bad includes of nested thrift files in c_glib
> ---------------------------------------------
>
>                 Key: THRIFT-1582
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1582
>             Project: Thrift
>          Issue Type: Bug
>          Components: C glib - Compiler
>    Affects Versions: 0.8, 0.9
>         Environment: When trying to compile the attached files the generated 
> code does not compile.
>            Reporter: José Antonio Santos
>            Assignee: José Antonio Santos
>              Labels: patch
>             Fix For: 0.8, 0.9
>
>         Attachments: firstTest.thrift, second.thrift, 
> thrift-1582-c_glib_generator.patch
>
>
> The generated code of the header looks like
> {code:title=second_types.h}
> ...
> /* other thrift includes */
> #include "firstTest_types.h"
> ...
> {code}
> But should look like:
> {code:title=second_types.h}
> ...
> /* other thrift includes */
> #include "first_test_types.h"
> ...
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to