GitHub user izuk opened a pull request:
https://github.com/apache/thrift/pull/20
Trunk
Modernising the Haskell library a bit:
* Use unordered-containers instead of basic Set/Map.
* Use Text instead of String.
* Use Vector instead of [].
This could probably use some critical review. I'm not a Haskell expert.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/izuk/thrift trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/20.patch
----
commit d5a6961b2ab896fe44ad85ee9c320af9758ef8c5
Author: Itai Zukerman <[email protected]>
Date: 2012-04-26T11:23:33-07:00
Add Hashable instances for all types.
* Hashable for Data.Map.Map and Data.Set.Set.
* Hashable for enums.
* Hashable for structs.
commit 84beb11822b5e3a43110e9e9cdb3b2badd69eaf5
Author: Itai Zukerman <[email protected]>
Date: 2012-04-26T11:59:19-07:00
Replace Map, Set with HashMap, HashSet.
commit 31508faf4839d47489e7df040e348e538777333c
Author: Itai Zukerman <[email protected]>
Date: 2012-04-25T17:28:09-07:00
Use Vector instead of plain [].
commit 8700fa0c8b652ab36544ed763832ca3500c6e516
Author: Itai Zukerman <[email protected]>
Date: 2012-04-25T16:00:17-07:00
Switch from String to Text in the Haskell library.
* readString, writeString now operate on Text.
* Fixed UTF8 bug (readString . writeString != id).
* Exceptions still have String messages.
commit 37527b8cdf78cb35729f42c0063cdf319fd630cf
Author: Itai Zukerman <[email protected]>
Date: 2012-04-26T12:13:02-07:00
Compile Haskell library with -O2 -W.
* Add Ghc-Options to cabal.
* Silence some warnings.
commit cb3cfecb3f5e5d0886a9fea22c01195d1f24f3d2
Author: Itai Zukerman <[email protected]>
Date: 2012-04-26T14:24:19-07:00
Add Hashable instance for Vector.
commit cfc159231b9b6398383d5a56d7879f3390e16f38
Author: Itai Zukerman <[email protected]>
Date: 2012-05-07T13:03:08-07:00
Switch to strict maps.
* Use Data.HashMap.Strict.
* Update README.
----
