[
https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401694#comment-13401694
]
Aalok Shah commented on THRIFT-1600:
------------------------------------
Hi Jake, Atul, and Matt,
I am pomack on github and I wasn't aware of this JIRA (don't subscribe). A few
people have reached out to me separately and I've helped them get up and
running individually. The version of Go in the Apache Thrift distribution is
from roughly Go-r59 or r60
https://github.com/pomack/thrift4go works for Go1 with the following known
caveats:
1) An empty thrift file can cause errors because Go will complain about an
empty compiled package.
2) Specifying services without any types/structs causes "import not used" error
messages. The thrift4go compiler creates an empty file for types.
3) Referring to functions/types from an imported thrift file doesn't scope the
functions/types in the generated code. A workaround is to change statements
from "import a" to "import . a" but that can cause naming conflicts. This
requires proper thrift4go compiler support.
4) Generated Makefiles still use pre-Go1 Makefiles that need to be updated to
use Go1 standards
5) Always generates packages under directory thriftlib/
I didn't want to push my changes out to the official thrift repository until
these were resolved, but I don't have the time to work on these issues in the
near future.
> Thrift Go Compiler and Library out of date with Go 1 Release.
> -------------------------------------------------------------
>
> Key: THRIFT-1600
> URL: https://issues.apache.org/jira/browse/THRIFT-1600
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler, Go - Library
> Reporter: Atul S Vasu
> Attachments: partial.diff
>
>
> Go 1 is a major release of Go that will be stable in the long term. Read the
> Go 1 Release Notes for more information.
> http://golang.org/doc/go1.html
> The current (trunk) compiler and libraries are not compatible with Go1,
> because of significant changes in the language.
> The pomack/thrift4go seems a valid patch, but doesn't seem to be pulled into
> Apache Thrift. Possibly merge the development into one place?
> https://github.com/pomack/thrift4go
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
