Cool, thanks. I am having issues getting the tests to pass, on a clean copy of the latest trunk.
On OS X TFileTransportTest fails with: Running 5 test cases... TFileTransportTest.cpp:282: error in "test_flush_max_us1": check calls->size() > static_cast<FsyncLog::CallList::size_type>(1) failed [1 <= 1] TFileTransportTest.cpp:282: error in "test_flush_max_us2": check calls->size() > static_cast<FsyncLog::CallList::size_type>(1) failed [1 <= 1] TFileTransportTest.cpp:282: error in "test_flush_max_us3": check calls->size() > static_cast<FsyncLog::CallList::size_type>(1) failed [1 <= 1] *** 3 failures detected in test suite "TFileTransportTest" On Ubuntu the same test fails with: Running 5 test cases... TFileTransportTest.cpp(340): fatal error in "test_noop_flush": critical check delta < 2000000 failed [3000379 >= 2000000] *** 1 failure detected in test suite "TFileTransportTest" Looking at the source of that test, this would appear to be a regression, as the test is intended to catch exactly this occurrence. Are these known issues? Also, if I edit test/AnnotationTest.thrift and deliberately fill it with gibberish, and then run 'make check' at the root, I don't see any compile error (I do see the unrelated TFileTransportTest error above). Do these files belong to some other tests that aren't run with 'make check'. If so, how do I run those? Thanks!! Benjy On Tue, Jul 10, 2012 at 6:16 PM, Jake Farrell <[email protected]> wrote: > We always welcome new functionality and patches, please see > http://thrift.apache.org/docs/HowToContribute/ for how to submit a patch > > -Jake > > > > On Tue, Jul 10, 2012 at 7:00 PM, Benjy Weinberger <[email protected]> wrote: > >> Thrift currently allows annotations on all elements other than enum >> and senum (and their values). Is this by design, or is it oversight? >> If the latter, any objection to me submitting a patch to allow those >> annotations? >> >> Thanks! >> >> Benjy >>
