[ 
https://issues.apache.org/jira/browse/THRIFT-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423964#comment-13423964
 ] 

Hudson commented on THRIFT-1662:
--------------------------------

Integrated in Thrift #513 (See [https://builds.apache.org/job/Thrift/513/])
    Thrift-1662:"removeObject:" should be "removeObserver:" in [-TSocketServer 
dealloc]?
Client: cocoa
Patch: Ken Morishita

Fixed issue there TSockerServer was using wrong notification center method. 
Using
- (void)removeObserver:(id)notificationObserver (Revision 1366424)

     Result = SUCCESS
                
> "removeObject:" should be "removeObserver:" in [-TSocketServer dealloc]?
> ------------------------------------------------------------------------
>
>                 Key: THRIFT-1662
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1662
>             Project: Thrift
>          Issue Type: Bug
>          Components: Cocoa - Library
>    Affects Versions: 0.8
>            Reporter: Ken Morishita
>            Assignee: Jake Farrell
>             Fix For: 0.9
>
>
> in lib/cocoa/src/server/TSocketServer.m
> ---------------------------------------- this may be wrong
> - (void) dealloc {
>    [[NSNotificationCenter defaultCenter] removeObject:self];
> ---------------------------------------- this may be correct
> - (void) dealloc {
>   [[NSNotificationCenter defaultCenter] removeObserver:self];
> ----------------------------------------
> isn't it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to