[ 
https://issues.apache.org/jira/browse/THRIFT-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432135#comment-13432135
 ] 

David Nadlinger commented on THRIFT-1674:
-----------------------------------------

Sorry, I had the changes lying around locally for some time, but apparently I 
forgot to send them off while trying to make sure that DMD 2.060 wouldn't be 
released with any of the genuine regressions the Thrift test suite uncovered.

As I don't have SVN access, somebody please commit the patches. Apart from the 
hastily written commit messages, they should be fine to go in as-is. With them 
applied, the test suite should also pass with DMD 2.060 on Linux and OS X.
                
> Update Thrift D library to be compatible with 2.060
> ---------------------------------------------------
>
>                 Key: THRIFT-1674
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1674
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Library
>    Affects Versions: 0.8
>         Environment: non-Windows
>            Reporter: Chad Retz
>         Attachments: 
> 0001-THRIFT-1674-Fix-use-of-final-switch-statements.patch, 
> 0002-THRIFT-1674-Avoid-using-deprecated-std.socket-APIs.patch, 
> 0003-THRIFT-1674-Fix-broken-unittest.patch, 
> 0004-THRIFT-1674-Use-global-errno-property-instead-of-get.patch
>
>
> D support was added before the latest D 2.060 release (via THRIFT-1500). Some 
> things have changed in 2.060. Specifically, when core.stdc.errno.getErrno is 
> accessed 
> [here|https://github.com/apache/thrift/blob/b95b0ffa720ffdebd829861ed420d10deab6c852/lib/d/src/thrift/internal/socket.d#L74],
>  it throws an error because it was made private 
> [here|https://github.com/D-Programming-Language/druntime/commit/901e81d58429756017fbf6c42158148e7872c8fa#L3R25].
> I'm still testing with other items on non-Windows setups, but I might submit 
> a patch to fix this soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to