On Sat, 15 Sep 2012 20:45:30 -0500 Ben Craig <[email protected]> wrote:
> I have a similar (all in one) patch that I can post on Monday. Good to hear, happy to work with you. > One thing I noticed in your patch was that you still cast the SOCKET > type to int in several places. This will appear to work most of the > time on Win64, but the upper 32 bits are used in some situations. > Discarding the upper 32-bits will cause problems in those situations. Thanks for pointing that out. THRIFT_SAFE_CAST should be used for now. The real solution is to define a ThriftSocket type dependent on OS, and use that to define all parameters. > The patch doesn't address the non-blocking server (which is fine, my > patch won't either). It also doesn't address some HANDLE->int casts > in the PipeServer that show up when you enable Visual Studio's /WP64 > warning flag (again, neither will mine). True. I'm not using those servers. Regards, --jkl
