[ 
https://issues.apache.org/jira/browse/THRIFT-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460586#comment-13460586
 ] 

Sergei Petrunia commented on THRIFT-579:
----------------------------------------

Hello,

+1 vote for getting this into trunk!

I've tried using THRIFT-579_v2_against_trunk_1304085.patch, and after I applied 
the suggestion by Michiel Ephraim, it compiled.  My async client worked for me 
so far, except for one problem: the library doesn't notify the client when 
connection could not be established.

This is caused by a missing part in the code, check out 
lib/cpp/src/async/TAsioAsync.cpp, function
TAsioClient::handleConnect().  It has comment that says "Todo: call 
user-provided errback".


                
> Alternative ASIO based fully async client/server for C++
> --------------------------------------------------------
>
>                 Key: THRIFT-579
>                 URL: https://issues.apache.org/jira/browse/THRIFT-579
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: C++ - Compiler, C++ - Library
>            Reporter: Bruce Simpson
>         Attachments: CppClient.cpp, CppServer.cpp, erikb-asio.patch, 
> TAsioAsync.cpp, TAsioAsync.h, TAsync.h, TFuture.h, 
> THRIFT-579_against_trunk_1243124.patch, 
> THRIFT-579_v2_against_trunk_1304085.patch, thrift-async-817938.diff
>
>
> I'm raising this JIRA on behalf of Erik Bernhardsson.
> Seems this was submitted to the JIRA list on Wed 9 Sep 2009, but I didn't see 
> it until I skimmed the JIRA list feed for thrift-dev.
> I'll attach his original files shortly, though I may just fold them into an 
> SVN trunk checkout first and post the diff.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to