[
https://issues.apache.org/jira/browse/THRIFT-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henrique Mendonca updated THRIFT-336:
-------------------------------------
Attachment: TCompactProtocol.cs
THRIFT-336.patch
I'd commit this if nobody has anything against it. I've converted it from the
java version and although I've tested quite a lot against the c++ version I
think I'll try to change its test script to also accept the new protocol.
Another two things:
1. I've left all references to trans.getBytesRemainingInBuffer() commented out,
I'm not sure if this is a java thing only but the normal binary protocol does
not have anything similar.
2. I run into problems encoding integers larger than 0x40000000 due to issues
involving shift on signed integers. I am pretty sure the VarInt and ZigZag type
have to be handled as an unsigned. This is the only change on the code from the
original Java implementation and I think it could be that this problem would
also happen there.
I'd be glad if someone could have a look on that (and/or on the Java version).
Thank you
> Compact Protocol in C#
> ----------------------
>
> Key: THRIFT-336
> URL: https://issues.apache.org/jira/browse/THRIFT-336
> Project: Thrift
> Issue Type: Sub-task
> Components: C# - Library
> Reporter: Michael Greene
> Assignee: Henrique Mendonca
> Priority: Minor
> Attachments: TCompactProtocol.cs, THRIFT-336.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
