[
https://issues.apache.org/jira/browse/THRIFT-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462015#comment-13462015
]
Henrique Mendonca commented on THRIFT-1701:
-------------------------------------------
I think you have a good point and I'm committing it but it unfortunately
doesn't fix the TBufferedTransport.
e.g.
thrift/test/nodejs$ timeout 2 make server & sleep 1; make client
only runs one or two tests before stopping/crashing when using
TBufferedTransport.
> node.js TBufferedTransport buffer corruption
> --------------------------------------------
>
> Key: THRIFT-1701
> URL: https://issues.apache.org/jira/browse/THRIFT-1701
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Reporter: Marshall Roch
> Attachments: thrift-1701-node-buffer-corruption.patch
>
>
> Node's Buffer.copy's 3rd and 4th arguments are the start and end indexes to
> copy. There are two callers in the nodejs implementation of
> TBufferedTransport that pass a length instead of an end index as the 4th
> argument.
> http://nodejs.org/api/buffer.html#buffer_buf_copy_targetbuffer_targetstart_sourcestart_sourceend
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
