[
https://issues.apache.org/jira/browse/THRIFT-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469586#comment-13469586
]
Hudson commented on THRIFT-1690:
--------------------------------
Integrated in Thrift #543 (See [https://builds.apache.org/job/Thrift/543/])
THRIFT-1690 Sockets and Pipe Handles truncated on Win64
Patch: Ben Craig (Revision 1394182)
Result = FAILURE
roger : http://svn.apache.org/viewvc/?view=rev&rev=1394182
Files :
* /thrift/trunk/lib/cpp/src/thrift/concurrency/BoostMonitor.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/TimerManager.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Util.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Util.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc
* /thrift/trunk/lib/cpp/src/thrift/protocol/TDebugProtocol.cpp
* /thrift/trunk/lib/cpp/src/thrift/protocol/TDenseProtocol.cpp
* /thrift/trunk/lib/cpp/src/thrift/protocol/TJSONProtocol.cpp
* /thrift/trunk/lib/cpp/src/thrift/protocol/TProtocol.h
* /thrift/trunk/lib/cpp/src/thrift/server/TThreadPoolServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TBufferTransports.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TBufferTransports.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TFDTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TFileTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TFileTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpClient.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TPipe.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TPipe.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TPipeServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TPipeServer.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TServerSocket.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TServerSocket.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TSocket.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TSocket.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TSocketPool.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TSocketPool.h
* /thrift/trunk/lib/cpp/src/thrift/windows/SocketPair.cpp
* /thrift/trunk/lib/cpp/src/thrift/windows/SocketPair.h
* /thrift/trunk/lib/cpp/src/thrift/windows/StdAfx.h
* /thrift/trunk/lib/cpp/src/thrift/windows/WinFcntl.cpp
* /thrift/trunk/lib/cpp/src/thrift/windows/WinFcntl.h
* /thrift/trunk/lib/cpp/src/thrift/windows/config.h
* /thrift/trunk/lib/cpp/src/thrift/windows/force_inc.h
> Sockets and Pipe Handles truncated on Win64
> -------------------------------------------
>
> Key: THRIFT-1690
> URL: https://issues.apache.org/jira/browse/THRIFT-1690
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: 64-bit Windows
> Reporter: Ben Craig
> Assignee: Roger Meier
> Attachments: libthrift_pipe_size.patch, libthrift_warning_purge.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> On 64-bit Windows, "int" is a 32-bit value. SOCKET and HANDLE are 64-bit.
> All of the files dealing with sockets in thrift use "int" as the type of a
> socket, as this is the idiomatic way to handle sockets on POSIX systems. For
> portability, a SOCKET typedef is probably needed.
> For the Pipe Server and Pipe Transport, HANDLEs are cast to ints to store as
> member variables for some reason (maybe to avoid #including <windows.h> in a
> header?).
> Both of these situations can result in invalid handles being used (and valid
> handles being leaked) when the system is under load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
