[
https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484550#comment-13484550
]
John Eckhart commented on THRIFT-1353:
--------------------------------------
I appreciate that you can't copy that file without following your process;
however, I am pointing out that your most recent merge missed a file and
therefore broke the node client. The missing file is also in the patch that the
original author attached to the ticket after following the contribution process.
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at
> https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the
> performance branch seems focused on this very issue. Also it includes the
> excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
