[
https://issues.apache.org/jira/browse/THRIFT-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496568#comment-13496568
]
Hudson commented on THRIFT-1748:
--------------------------------
Integrated in Thrift #581 (See [https://builds.apache.org/job/Thrift/581/])
THRIFT-1748 Guard and RWGuard macros defined in global namespace
Patch: Bud Bundy (Revision 1406793)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1406793
Files :
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Mutex.h
> Guard and RWGuard macros defined in global namespace
> ----------------------------------------------------
>
> Key: THRIFT-1748
> URL: https://issues.apache.org/jira/browse/THRIFT-1748
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Visual Studio 2010
> Reporter: Bud Bundy
> Assignee: Roger Meier
> Priority: Trivial
> Labels: newbie, patch
> Fix For: 1.0
>
>
> thrift/concurrency/Mutex.h defines global macros Guard and RWGuard. Although
> the purpose is well commented and appreciated - i.e. trying to prevent coders
> from creating temporary variables and falsely assuming they have a lock -
> this code does interfere with other packages that define their own Guard
> classes. Even when the user/library define Guard in their own namespace,
> there's a clash.
> Please remove the macros.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
