[
https://issues.apache.org/jira/browse/THRIFT-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Beyer updated THRIFT-1699:
---------------------------------
Attachment: THRIFT-1699-remove-extra-read-field-end.patch
I applied the patch and tested it on Mac OS X Lion with Ruby 1.9.3-p327. All of
the Ruby tests passed fine.
The original patch wasn't a unified patch and a bit painful to apply via
'patch', so I regenerated it via 'svn diff' and uploaded the file as
[^THRIFT-1699-remove-extra-read-field-end.patch].
> Native Union#read has extra read_field_end call
> -----------------------------------------------
>
> Key: THRIFT-1699
> URL: https://issues.apache.org/jira/browse/THRIFT-1699
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Library
> Affects Versions: 0.8
> Reporter: Kevin Radloff
> Attachments: rb-struct.diff,
> THRIFT-1699-remove-extra-read-field-end.patch
>
>
> The native implementation of the Union#read method has an extraneous call to
> read_field_end. This makes no difference to most protocols because
> read_field_end is a no-op, but it breaks JSON (in this case my own class, not
> the one in trunk), which does do something in this method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
